Issue 115354: Raise an human readable exception if an unversioned directory exists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115354: Raise an human readable exception if an unversioned directory exists. (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Raise an human readable exception if an unversioned directory exists. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16156

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	gclient.py	View		1 chunk	+4 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sgk

11 years, 7 months ago (2009-05-15 05:18:29 UTC) #2

lgtm

http://codereview.chromium.org/115354/diff/1/2
File gclient.py (right):

http://codereview.chromium.org/115354/diff/1/2#newcode792
Line 792: raise Error("Can't update/checkout %s if an unversioned directory is "
Nit:  I prefer %r in messages like this so the string is quoted.  The error
message is more readable if something weird happens and the value is a null
string.

Expand Messages | Collapse Messages