Reduce the memory used by frame elements from two words to one by...

src/compiler.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 11 matching lines @@
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #ifndef V8_COMPILER_H_
 #define V8_COMPILER_H_
 
 #include "parser.h"
+#include "zone.h"
+#include "frame-element.h"

[Kevin Millikin (Chromium), 2009/05/14 11:29:02]

Is it OK to alphabetize these?

[Mads Ager (chromium), 2009/05/14 11:42:40]

It is.  Done.

 
 namespace v8 { namespace internal {
 
 // The V8 compiler
 //
 // General strategy: Source code is translated into an anonymous function w/o
 // parameters which then can be executed. If the source code contains other
 // functions, they will be compiled and allocated as part of the compilation
 // of the source code.
 
@@ skipping 20 matching lines @@
                                         int line_offset,
                                         bool is_global,
                                         bool is_json);
 
   // Compile from function info (used for lazy compilation). Returns
   // true on success and false if the compilation resulted in a stack
   // overflow.
   static bool CompileLazy(Handle<SharedFunctionInfo> shared, int loop_nesting);
 };
 
+
+// During compilation we need a global list of handles to constants
+// for frame elements.  When the zone gets deleted, we make sure to
+// clear this list of handles as well.
+class CompilationZoneScope : public ZoneScope {
+ public:
+  CompilationZoneScope(ZoneScopeMode mode) : ZoneScope(mode) { };
+  virtual ~CompilationZoneScope() {
+    if (ShouldDeleteOnExit()) FrameElement::ClearConstantList();
+  };
+};
+
+
 } }  // namespace v8::internal
 
 #endif  // V8_COMPILER_H_