Issue 115320: Don't try to compile .mk files when building shared libraries...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115320: Don't try to compile .mk files when building shared libraries... (Closed)

Created:
11 years, 7 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Craig Schlenter, bradnelson, bradn

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Don't try to compile .mk files when building shared libraries (to exclude third_party/skia/src/core/core_files.mk). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15999

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	site_scons/site_tools/chromium_builders.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Craig Schlenter

11 years, 7 months ago (2009-05-14 05:09:14 UTC) #3

r15979 removed third_party/skia/src/core/core_files.mk from skia.gyp btw. ... I
assume that was ok to do and that nothing actually needed that? It passed on the
try servers but I thought I'd check just in case it is actually useful in some
way.

Expand Messages | Collapse Messages