Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1153005: Move the dev server script to src/scripts and remove the .sh extension. (Closed)

Created:
10 years, 9 months ago by petkov
Modified:
9 years, 7 months ago
Reviewers:
gauravsh, sosa
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Move the dev server script to src/scripts and remove the .sh extension.

Patch Set 1 #

Total comments: 2

Patch Set 2 : update the copyright. #

Patch Set 3 : Rename to use underscore for consistency. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
A + src/scripts/start_devserver View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
petkov
10 years, 9 months ago (2010-03-19 22:58:24 UTC) #1
sosa
Lgtm!
10 years, 9 months ago (2010-03-19 23:01:04 UTC) #2
gauravsh
lgtm to you too. http://codereview.chromium.org/1153005/diff/1/2 File src/scripts/start-devserver (right): http://codereview.chromium.org/1153005/diff/1/2#newcode3 src/scripts/start-devserver:3: # Copyright (c) 2009 The ...
10 years, 9 months ago (2010-03-19 23:02:56 UTC) #3
petkov
Submitting... http://codereview.chromium.org/1153005/diff/1/2 File src/scripts/start-devserver (right): http://codereview.chromium.org/1153005/diff/1/2#newcode3 src/scripts/start-devserver:3: # Copyright (c) 2009 The Chromium OS Authors. ...
10 years, 9 months ago (2010-03-19 23:07:18 UTC) #4
petkov
Actually, renamed again to use underscore for consistency. PTAL
10 years, 9 months ago (2010-03-19 23:09:04 UTC) #5
sosa
10 years, 9 months ago (2010-03-19 23:10:36 UTC) #6
Looks better to me

Powered by Google App Engine
This is Rietveld 408576698