Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1126)

Issue 115266: Add valgrind suppression for libxml error in http://crbug.com/11838 (Closed)

Created:
11 years, 7 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
dank
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add valgrind suppression for libxml error in http://crbug.com/11838 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15913

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M tools/valgrind/suppressions.txt View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
11 years, 7 months ago (2009-05-12 22:04:42 UTC) #1
dank
11 years, 7 months ago (2009-05-12 22:19:52 UTC) #2
LGTM.

When the stack includes an obvious clue that the problem is
in a test, please make the suppression specific to the test
or all tests initially.  I have a feeling we want the error to
show up when valgrinding chromium proper.  But either way is
fine, as it's seldom possible to make the suppressions specific
to tests, and I often end up widening them anyway.

Powered by Google App Engine
This is Rietveld 408576698