Issue 115261: Add presubmit checks to look for BUG= and TEST= tags in change list description.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115261: Add presubmit checks to look for BUG= and TEST= tags in change list description. (Closed)

Created:
11 years, 7 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews_googlegroups.com, Mark Larson

Visibility:
Public.

Description

Add presubmit checks to look for BUG= and TEST= tags in change list description (Part 2 of 2). BUG=11287 TEST=gcl commit should fail unless BUG= & TEST= exist in change list description or --no_presubmit is used.

Patch Set 1 #

Patch Set 2 : iff master #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	PRESUBMIT.py	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

kuchhal

Right now this change will generate error and can only be suppressed by --no_presubmit or ...

11 years, 7 months ago (2009-05-12 20:21:08 UTC) #1

M-A Ruel

11 years, 7 months ago (2009-05-12 20:30:34 UTC) #2

Maybe have a warning on upload and an error on commit. I don't know if it's
doable with the current infrastructure.

lgtm anyway

Expand Messages | Collapse Messages