Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 115252: - Fix build break on Mac OS X by using the proper formatting for pointers.... (Closed)

Created:
11 years, 7 months ago by iposva
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

- Fix build break on Mac OS X by using the proper formatting for pointers by working around slightly "wrong" definition of uintptr_t on Mac OS X. Verified that this works on both ia32 and x64 on Linux and Mac OS X. Committed: http://code.google.com/p/v8/source/detail?r=1938

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M SConstruct View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/globals.h View 1 2 1 chunk +11 lines, -3 lines 2 comments Download
M src/platform-macos.cc View 1 2 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
iposva
11 years, 7 months ago (2009-05-12 19:03:51 UTC) #1
iposva
11 years, 7 months ago (2009-05-12 22:00:59 UTC) #2
Erik Corry
LGTM
11 years, 7 months ago (2009-05-12 22:22:23 UTC) #3
Dean McNamee
http://codereview.chromium.org/115252/diff/1007/1009 File src/globals.h (right): http://codereview.chromium.org/115252/diff/1007/1009#newcode95 Line 95: #define V8PRIxPTR "lx" We need Id also, it ...
11 years, 7 months ago (2009-05-13 08:24:21 UTC) #4
iposva
Addressed review comments.
11 years, 7 months ago (2009-05-13 16:37:08 UTC) #5
Dean McNamee
Ok http://codereview.chromium.org/115252/diff/1014/10 File src/globals.h (right): http://codereview.chromium.org/115252/diff/1014/10#newcode92 Line 92: // Fix for Mac OS X defining ...
11 years, 7 months ago (2009-05-13 16:40:59 UTC) #6
iposva
http://codereview.chromium.org/115252/diff/1014/10 File src/globals.h (right): http://codereview.chromium.org/115252/diff/1014/10#newcode92 Line 92: // Fix for Mac OS X defining uintptr_t ...
11 years, 7 months ago (2009-05-13 16:54:50 UTC) #7
Dean McNamee
11 years, 7 months ago (2009-05-13 17:00:34 UTC) #8
Ok, we should try to clean up the intptr_t/ptrdiff_t etc situation, but
unbreaking the build for now is obviously a good thing to do.

Thanks

Powered by Google App Engine
This is Rietveld 408576698