Issue 115236: Fix for issue 341. In the stub for instanceof, we could try to read...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115236: Fix for issue 341. In the stub for instanceof, we could try to read... (Closed)

Created:
11 years, 7 months ago by Kevin Millikin (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix for issue 341. In the stub for instanceof, we could try to read an object's map before we were sure it was a heap object. Committed: http://code.google.com/p/v8/source/detail?r=1914

Patch Set 1 #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -0 lines)			Patch
	M	src/ia32/codegen-ia32.cc	View		1 chunk	+2 lines, -0 lines	2 comments	Download
	A	test/mjsunit/regress/regress-341.js	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/115236/diff/1/3 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/115236/diff/1/3#newcode7189 Line 7189: __ mov(eax, FieldOperand(eax, HeapObject::kMapOffset)); // ebx - ...

11 years, 7 months ago (2009-05-12 11:32:12 UTC) #2

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-05-12 11:39:46 UTC) #3

http://codereview.chromium.org/115236/diff/1/3
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/115236/diff/1/3#newcode7189
Line 7189: __ mov(eax, FieldOperand(eax, HeapObject::kMapOffset));  // ebx -
object map
On 2009/05/12 11:32:12, Kasper Lund wrote:
> Why does this say ebx - object map?

Weird.

Expand Messages | Collapse Messages