Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issue 115227: Add new Splay benchmark to the V8 benchmark suite and remove... (Closed)

Created:
11 years, 7 months ago by Kasper Lund
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add new Splay benchmark to the V8 benchmark suite and remove the unused parts (most) of the Prototype library from raytrace.js. Committed: http://code.google.com/p/v8/source/detail?r=1910

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 1

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+471 lines, -2530 lines) Patch
M benchmarks/README.txt View 1 chunk +12 lines, -0 lines 0 comments Download
M benchmarks/base.js View 1 2 3 4 5 chunks +41 lines, -9 lines 0 comments Download
M benchmarks/deltablue.js View 1 chunk +4 lines, -4 lines 0 comments Download
M benchmarks/earley-boyer.js View 1 chunk +0 lines, -1 line 0 comments Download
M benchmarks/raytrace.js View 3 chunks +10 lines, -2509 lines 0 comments Download
M benchmarks/revisions.html View 3 chunks +17 lines, -1 line 0 comments Download
M benchmarks/richards.js View 1 chunk +1 line, -1 line 0 comments Download
M benchmarks/run.html View 1 2 3 3 chunks +7 lines, -5 lines 0 comments Download
M benchmarks/run.js View 1 chunk +1 line, -0 lines 0 comments Download
A benchmarks/splay.js View 1 2 3 4 5 6 1 chunk +378 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kasper Lund
11 years, 7 months ago (2009-05-12 07:01:45 UTC) #1
Mads Ager (chromium)
LGTM http://codereview.chromium.org/115227/diff/1/5 File benchmarks/base.js (right): http://codereview.chromium.org/115227/diff/1/5#newcode37 Line 37: // not accounted for in the benchmark ...
11 years, 7 months ago (2009-05-12 07:16:02 UTC) #2
Erik Corry
LGTM. http://codereview.chromium.org/115227/diff/1/5 File benchmarks/base.js (right): http://codereview.chromium.org/115227/diff/1/5#newcode122 Line 122: window.setTimeout(RunStep, 10); But why? http://codereview.chromium.org/115227/diff/1/3 File benchmarks/splay.js ...
11 years, 7 months ago (2009-05-12 07:25:34 UTC) #3
Erik Corry
11 years, 7 months ago (2009-05-12 08:04:16 UTC) #4
LGTM

http://codereview.chromium.org/115227/diff/28/1025
File benchmarks/splay.js (right):

http://codereview.chromium.org/115227/diff/28/1025#newcode104
Line 104: if (keys[i] > keys[i + 1]) {
Shouldn't this be >= if the keys are required to be unique?

Powered by Google App Engine
This is Rietveld 408576698