Issue 11522: Change the handling of OS::Abort on Windows to enter the debugger if the proc...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11522: Change the handling of OS::Abort on Windows to enter the debugger if the proc... (Closed)

Created:
12 years, 1 month ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Change the handling of OS::Abort on Windows to enter the debugger if the process is being debugged. Committed: http://code.google.com/p/v8/source/detail?r=802

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -4 lines)			Patch
	M	src/platform-win32.cc	View	1	2 chunks	+13 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

Mads Ager (chromium)

LGTM, could you add a commit to the #define at the top of the file.

12 years, 1 month ago (2008-11-20 09:57:15 UTC) #2

Søren Thygesen Gjesse

12 years, 1 month ago (2008-11-20 09:59:44 UTC) #3

Added comment

// Require Windows 2000 or higher (this is required for the IsDebuggerPresent
// function to be present).