Issue 115204: Add a separate cookie store that's used for extensions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115204: Add a separate cookie store that's used for extensions.... (Closed)

Created:
11 years, 7 months ago by Matt Perry

Modified:
9 years, 7 months ago

Reviewers:
Dean McNamee

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a separate cookie store that's used for extensions. Modify CookieMonster to support overriding the "cookieable schemes". Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=16083

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -50 lines)			Patch
M	chrome/browser/browser_init.cc	View	3	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/browser_main.cc	View	3	2 chunks	+7 lines, -0 lines	1 comment	Download
M	chrome/browser/net/chrome_url_request_context.h	View	1 2	2 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/browser/net/chrome_url_request_context.cc	View	1 2	3 chunks	+35 lines, -0 lines	0 comments	Download
M	chrome/browser/profile.h	View	1 2	4 chunks	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/profile.cc	View	1 2	9 chunks	+50 lines, -30 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.cc	View	1 2	3 chunks	+10 lines, -4 lines	0 comments	Download
M	chrome/common/chrome_constants.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/chrome_constants.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/testing_profile.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	net/base/cookie_monster.h	View	1 2	5 chunks	+13 lines, -0 lines	0 comments	Download
M	net/base/cookie_monster.cc	View	1 2	7 chunks	+19 lines, -12 lines	1 comment	Download
M	net/base/cookie_monster_unittest.cc	View	1 2	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 7 months ago (2009-05-14 07:34:38 UTC) #1

I still think this is a bad idea, but I realize it's going to happen no matter
what I think.

Technically I don't have any more to complain about.  I didn't think super hard
about edge cases, effective TLD, and all of this other stuff that happens in
cookies, so I wouldn't be surprised if something doesn't work right.

http://codereview.chromium.org/115204/diff/47/61
File chrome/browser/browser_main.cc (right):

http://codereview.chromium.org/115204/diff/47/61#newcode371
Line 371: // Profile (and therefore first CookieMonster) is created.
the first

http://codereview.chromium.org/115204/diff/47/50
File net/base/cookie_monster.cc (right):

http://codereview.chromium.org/115204/diff/47/50#newcode133
Line 133: SetCookieableSchemes(kDefaultCookieableSchemes, num_schemes);
This is so much simpler, thanks.

Expand Messages | Collapse Messages