Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: chrome/chrome.gyp

Issue 115187: - Set the bundle name based on the executable name (since they both are the b... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/app-Info.plist ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome.gyp
===================================================================
--- chrome/chrome.gyp (revision 15752)
+++ chrome/chrome.gyp (working copy)
@@ -1924,14 +1924,10 @@
}],
],
'xcode_settings': {
- # chrome/app/app-Info.plist has a CFBundleIdentifier of BUNDLE_ID,
- # to be replaced by a properly branded bundle ID in Xcode with
- # these settings.
- 'INFOPLIST_PREPROCESS': 'YES',
- 'INFOPLIST_PREPROCESSOR_DEFINITIONS': [
- 'BUNDLE_ID="<(bundle_id)"',
- 'BUNDLE_NAME="<(branding)"'
- ],
+ # chrome/app/app-Info.plist has a CFBundleIdentifier of
+ # CHROMIUM_BUNDLE_ID to be replaced by a branded bundle ID in Xcode
+ # with this settings.
+ 'CHROMIUM_BUNDLE_ID': '<(bundle_id)',
},
}, { # else: OS != "mac"
'conditions': [
@@ -1946,6 +1942,23 @@
}],
],
}],
+ ['OS=="mac"', {
+ # Mac addes an action to modify the Info.plist to meet our needs
+ # (see the script for why this is done).
+ 'actions': [
+ {
+ 'action_name': 'tweak_app_infoplist',
+ # We don't list any inputs or outputs because we always want
+ # the script to run. Why? Because it does thinks like record
+ # the svn revision into the info.plist, so there is no file to
+ # depend on that will change when ever that changes.
+ 'inputs': [],
+ 'outputs': [],
+ 'action': ['<(DEPTH)/build/mac/tweak_app_infoplist',
+ '<(branding)'],
+ },
+ ],
+ }],
['OS=="win"', {
'include_dirs': [
'third_party/wtl/include',
« no previous file with comments | « chrome/app/app-Info.plist ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698