Issue 115182: Do not define __ARMEL__ on ARM, this is the compilers job.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115182: Do not define ARMEL on ARM, this is the compilers job. (Closed)

Created:
11 years, 7 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, sgk

CC:
chromium-reviews_googlegroups.com, ryan.cairns

Visibility:
Public.

Description

Do not define __ARMEL__ on ARM, this is the compilers job.

Patch Set 1 #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	build/common.gypi	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sgk

11 years, 7 months ago (2009-05-11 17:38:58 UTC) #2

LGTM

CC:  ryan.cairns, to cover the unlikely event that this was actually necessary
for some future non-compiler command invocation that was intending to use the
'cflags' setting from gyp.

Expand Messages | Collapse Messages

Issue 115182: Do not define __ARMEL__ on ARM, this is the compilers job. (Closed)

Description

Patch Set 1 #

Messages

Issue 115182: Do not define ARMEL on ARM, this is the compilers job. (Closed)