Fix incorrect variable in LoadChangelistInfo and recognize directories properly in GenerateDiff.

Fix incorrect variable in LoadChangelistInfo and recognize directories properly in GenerateDiff.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15753

[Lei Zhang, 2009-05-11 06:50:46]

the status variable was from the old gcl.py...

[Lei Zhang, 2009-05-11 07:14:43]

On 2009/05/11 06:50:46, Lei Zhang wrote:
> the status variable was from the old gcl.py...

While we're at it, fix directory recognition. I was getting 2x upload for newly
added directories. i.e. see earlier patchsets to
http://codereview.chromium.org/113168.

[M-A Ruel, 2009-05-11 15:16:42]

I'll try to fix the status reporting ASAP

http://codereview.chromium.org/115179/diff/1003/5
File gcl.py (right):

http://codereview.chromium.org/115179/diff/1003/5#newcode534
Line 534: elif status_result[0][0] != file[0]:
Na, the status reported should be fixed instead.

http://codereview.chromium.org/115179/diff/1003/5#newcode536
Line 536: files[files.index(file)] = (status_result[0][0], file[1])
Too

http://codereview.chromium.org/115179/diff/1003/5#newcode751
Line 751: if GetSVNFileInfo(file).get("Node Kind") in ("dir", "directory"):
Oh, thanks!

[M-A Ruel, 2009-05-11 15:40:48]

http://codereview.chromium.org/115179/diff/1005/1006
File gcl.py (right):

http://codereview.chromium.org/115179/diff/1005/1006#newcode529
Line 529: status_result = GetSVNStatus(filename)
Do this instead:
status_result = GetSVNStatus(filename)[0]

http://codereview.chromium.org/115179/diff/1005/1006#newcode536
Line 536: if status != file[0]:
Change to:
if status_result[0] != file[0]:

[M-A Ruel, 2009-05-11 15:52:56]

lgtm