Add a 'cygwin' target to execute setup_mount.bat explicitly as a...

Add a 'cygwin' target to execute setup_mount.bat explicitly as a
dependency of targets that need it (that is, any target with
'rules' or 'actions').

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15774

[sgk, 2009-05-09 01:38:31]

This adds a build/win/system.gyp with a target for explicitly executing the
cygwin setup_mount.bat script.  All other targets that have 'actions' or 'rules'
on Windows get a dependency on 'system.gyp:cygwin' to execute setup_mount.bat
once when the run starts.

If this looks like an acceptable pattern for implementing this, I'll submit a
companion CL to remove the setup_mount.bat call from the prefix that the
generator uses for every command, and roll the DEPS in this CL.

[bradn, 2009-05-11 01:42:00]

LGTM

Eventually we should massage out the ones that don't really need cygwin (should
be all the python ones, just the perl will need it).

[Mark Mentovai, 2009-05-11 16:25:20]

I like this model.

http://codereview.chromium.org/115154/diff/1/7
File build/win/system.gyp (right):

http://codereview.chromium.org/115154/diff/1/7#newcode1
Line 1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
Remember to set svn:eol-style = LF (it's not clear, you may have set it.)

[Mark Mentovai, 2009-05-11 16:25:32]

...meaning LGTM...

[sgk, 2009-05-11 17:35:08]

Uploaded DEPS roll of gyp to remove the per-command setup_mount.bat call.  NRN,
will commit if the trybots come back successful.

http://codereview.chromium.org/115154/diff/1/7
File build/win/system.gyp (right):

http://codereview.chromium.org/115154/diff/1/7#newcode1
Line 1: # Copyright (c) 2009 The Chromium Authors. All rights reserved.
On 2009/05/11 16:25:20, Mark Mentovai wrote:
> Remember to set svn:eol-style = LF (it's not clear, you may have set it.)

Done.