Implement the popup blocking whitelist pref. This makes the whitelist actual...

base/values.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 #include "base/string_util.h"
 #include "base/values.h"
 
 ///////////////////// Value ////////////////////
 
@@ skipping 479 matching lines @@
   return true;
 }
 
 ///////////////////// ListValue ////////////////////
 
 ListValue::~ListValue() {
   Clear();
 }
 
 void ListValue::Clear() {
-  ValueVector::iterator list_iterator = list_.begin();
-  while (list_iterator != list_.end()) {
-    delete *list_iterator;
-    ++list_iterator;
-  }
+  for (ValueVector::iterator i(list_.begin()); i != list_.end(); ++i)
+    delete *i;
   list_.clear();
 }
 
 bool ListValue::Set(size_t index, Value* in_value) {
   if (!in_value)
     return false;
 
   if (index >= list_.size()) {
     // Pad out any intermediate indexes with null settings
     while (index > list_.size())
@@ skipping 87 matching lines @@
 
 bool ListValue::Remove(size_t index, Value** out_value) {
   if (index >= list_.size())
     return false;
 
   if (out_value)
     *out_value = list_[index];
   else
     delete list_[index];
 
-  ValueVector::iterator entry = list_.begin();
-  entry += index;
+  list_.erase(list_.begin() + index);
+  return true;
+}
 
-  list_.erase(entry);
-  return true;
+void ListValue::Remove(Value* in_value) {
+  for (ValueVector::iterator i(list_.begin()); i != list_.end(); ++i) {
+    if ((*i)->Equals(in_value)) {
+      list_.erase(i);
+      break;
+    }
+  }
 }
 
 void ListValue::Append(Value* in_value) {
   DCHECK(in_value);
   list_.push_back(in_value);
 }
 
 Value* ListValue::DeepCopy() const {
   ListValue* result = new ListValue;
 
-  ValueVector::const_iterator current_entry = list_.begin();
-  while (current_entry != list_.end()) {
-    result->Append((*current_entry)->DeepCopy());
-    ++current_entry;
-  }
+  for (ValueVector::const_iterator i(list_.begin()); i != list_.end(); ++i)
+    result->Append((*i)->DeepCopy());
 
   return result;
 }
 
 bool ListValue::Equals(const Value* other) const {
   if (other->GetType() != GetType())
     return false;
 
   const ListValue* other_list =
       static_cast<const ListValue*>(other);
   const_iterator lhs_it, rhs_it;
   for (lhs_it = begin(), rhs_it = other_list->begin();
        lhs_it != end() && rhs_it != other_list->end();
        ++lhs_it, ++rhs_it) {
     if (!(*lhs_it)->Equals(*rhs_it))
       return false;
   }
   if (lhs_it != end() || rhs_it != other_list->end())
     return false;
 
   return true;
 }