Issue 115142: Propagate official build variables from buildbot compile.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115142: Propagate official build variables from buildbot compile.py. (Closed)

Created:
11 years, 7 months ago by Michael Moss

Modified:
9 years, 7 months ago

Reviewers:
Nicolas Sylvain, TVL, sgk

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Propagate official build variables from buildbot compile.py.

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	build/common.gypi	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

TVL

http://codereview.chromium.org/115142/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/115142/diff/1/2#newcode219 Line 219: 'OFFICIAL_BUILD', why is this different then on mac? ...

11 years, 7 months ago (2009-05-08 20:17:10 UTC) #3

lgtm

Expand Messages | Collapse Messages