Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: net/ftp/ftp_transaction.h

Issue 115137: FTP Transaction code for new Portable FTP code.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Upload before checkin Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/ftp/ftp_response_info.h ('k') | net/ftp/ftp_transaction_factory.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/ftp/ftp_transaction.h
===================================================================
--- net/ftp/ftp_transaction.h (revision 15612)
+++ net/ftp/ftp_transaction.h (working copy)
@@ -6,6 +6,7 @@
#define NET_FTP_FTP_TRANSACTION_H_
#include "net/base/completion_callback.h"
+#include "net/base/io_buffer.h"
#include "net/base/load_states.h"
namespace net {
@@ -17,7 +18,7 @@
class FtpTransaction {
public:
// Stops any pending IO and destroys the transaction object.
- virtual void Destroy() = 0;
+ virtual ~FtpTransaction() {}
// Starts the FTP transaction (i.e., sends the FTP request).
//
@@ -54,7 +55,9 @@
//
// NOTE: The transaction is not responsible for deleting the callback object.
//
- virtual int Read(char* buf, int buf_len, CompletionCallback* callback) = 0;
+ virtual int Read(IOBuffer* buf,
+ int buf_len,
+ CompletionCallback* callback) = 0;
// Returns the response info for this transaction or NULL if the response
// info is not available.
@@ -64,7 +67,7 @@
virtual LoadState GetLoadState() const = 0;
// Returns the upload progress in bytes. If there is no upload data,
- // zero will be returned. This does not include the request headers.
+ // zero will be returned.
virtual uint64 GetUploadProgress() const = 0;
};
« no previous file with comments | « net/ftp/ftp_response_info.h ('k') | net/ftp/ftp_transaction_factory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698