Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1864)

Issue 115125: A register allocation bugfix.... (Closed)

Created:
11 years, 7 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

A register allocation bugfix. The function that prepares a virtual frame slot for writing (in order to preserve the copy-on-write semantics of aliased frame elements) can allocate registers, which may spill one from the frame. If we're unlucky, the spilled register can be the source register for the frame element write. In that case, ensure we do the write from memory. Committed: http://code.google.com/p/v8/source/detail?r=1904

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/ia32/virtual-frame-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
This is annoyingly subtle behavior. It's convenient to have local names for frame elements. It's ...
11 years, 7 months ago (2009-05-08 10:20:37 UTC) #1
iposva
11 years, 7 months ago (2009-05-08 15:45:33 UTC) #2
LGTM

Have you filed a bug to go and identify other potential candidates?

-Ivan

Powered by Google App Engine
This is Rietveld 408576698