Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1151006: Update to current gtest/gmock. (Closed)

Created:
10 years, 9 months ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
awong, M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Update to current gtest/gmock. Synced in new gmock, twiddled DEPS for new gtest, updated README. BUG=34160 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42625

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1391 lines, -892 lines) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M testing/README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock/CHANGES View 1 chunk +24 lines, -0 lines 0 comments Download
M testing/gmock/Makefile.am View 2 chunks +8 lines, -0 lines 0 comments Download
M testing/gmock/README View 1 chunk +0 lines, -66 lines 0 comments Download
M testing/gmock/configure.ac View 3 chunks +23 lines, -2 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h View 31 chunks +132 lines, -57 lines 0 comments Download
M testing/gmock/include/gmock/gmock-generated-matchers.h.pump View 11 chunks +65 lines, -27 lines 0 comments Download
M testing/gmock/include/gmock/gmock-matchers.h View 57 chunks +479 lines, -456 lines 0 comments Download
M testing/gmock/include/gmock/gmock-printers.h View 6 chunks +14 lines, -34 lines 0 comments Download
M testing/gmock/include/gmock/gmock-spec-builders.h View 2 chunks +4 lines, -4 lines 0 comments Download
M testing/gmock/include/gmock/internal/gmock-port.h View 1 chunk +0 lines, -18 lines 0 comments Download
A testing/gmock/run_tests.py View 1 chunk +82 lines, -0 lines 0 comments Download
M testing/gmock/src/gmock-internal-utils.cc View 1 chunk +1 line, -1 line 0 comments Download
testing/gmock/src/gmock-spec-builders.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/gmock/test/gmock-generated-matchers_test.cc View 6 chunks +61 lines, -9 lines 0 comments Download
M testing/gmock/test/gmock-internal-utils_test.cc View 9 chunks +27 lines, -29 lines 0 comments Download
M testing/gmock/test/gmock-matchers_test.cc View 35 chunks +295 lines, -74 lines 0 comments Download
testing/gmock/test/gmock-nice-strict_test.cc View 4 chunks +15 lines, -11 lines 0 comments Download
M testing/gmock/test/gmock-printers_test.cc View 2 chunks +13 lines, -7 lines 0 comments Download
M testing/gmock/test/gmock-spec-builders_test.cc View 18 chunks +96 lines, -90 lines 0 comments Download
A testing/gmock/test/gmock_all_test.cc View 1 chunk +49 lines, -0 lines 0 comments Download
testing/gmock/test/gmock_link_test.h View 3 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Evan Martin
10 years, 9 months ago (2010-03-22 18:34:50 UTC) #1
Evan Martin
timeout on awong, trying m-a for rubber stampage
10 years, 9 months ago (2010-03-22 19:31:00 UTC) #2
M-A Ruel
On 2010/03/22 19:31:00, Evan Martin wrote: > timeout on awong, trying m-a for rubber stampage ...
10 years, 9 months ago (2010-03-22 19:33:49 UTC) #3
Evan Martin
On 2010/03/22 19:33:49, Marc-Antoine Ruel wrote: > On 2010/03/22 19:31:00, Evan Martin wrote: > > ...
10 years, 9 months ago (2010-03-22 19:34:46 UTC) #4
Evan Martin
Ok, check this out: http://build.chromium.org/buildbot/try-server/waterfall?branch=&committer=evan@chromium.org last two runs are this patch; note how both pass ...
10 years, 9 months ago (2010-03-25 00:52:04 UTC) #5
M-A Ruel
10 years, 9 months ago (2010-03-25 00:59:44 UTC) #6
Oh well.

At worst, reverting with git is easy. :P

lgtm


On 2010/03/25 00:52:04, Evan Martin wrote:
> Ok, check this out:
> 
>
http://build.chromium.org/buildbot/try-server/waterfall?branch=&committer=eva...
> 
> last two runs are this patch; note how both pass (well, are red in different
> places)

Powered by Google App Engine
This is Rietveld 408576698