Don't reinstall *every* time. Just if the batch file doesn't exist.

Don't reinstall *every* time. Just if the batch file doesn't exist.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15546

[sigurdur.asgeirsson_gmail.com, 2009-05-07 14:38:25]

http://codereview.chromium.org/115085/diff/1/2
File bootstrap/win/win_tools.bat (right):

http://codereview.chromium.org/115085/diff/1/2#newcode23
Line 23: if "%WIN_TOOLS_FORCE%" == "1" goto :SVN_FORCE
Won't this skip the SVN install if svn is present, even when force is specified?

http://codereview.chromium.org/115085/diff/1/2#newcode59
Line 59: if "%WIN_TOOLS_FORCE%" == "1" goto :PYTHON_INSTALL
ditto?

[M-A Ruel, 2009-05-07 14:42:05]

No because the line "call svn --version 2>nul 1>nul" is the one looking that svn
is actually installed. The previous one is just to test for the existence of the
stub batch file. This batch file presence in depot_tools\. is used as a signal
to determined if we tried pulling svn/python in depot_tools or not.

[sigurdur.asgeirsson_gmail.com, 2009-05-07 14:50:01]

On 2009/05/07 14:42:05, M-A wrote:
> No because the line "call svn --version 2>nul 1>nul" is the one looking that
svn
> is actually installed. The previous one is just to test for the existence of
the
> stub batch file. This batch file presence in depot_tools\. is used as a signal
> to determined if we tried pulling svn/python in depot_tools or not.

lgtm