Issue 115080: X64: Serialization fixed to use intptr_t/Address where needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115080: X64: Serialization fixed to use intptr_t/Address where needed. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Dean McNamee, Kasper Lund

CC:
v8-dev

Visibility:
Public.

Description

X64: Serialization fixed to use intptr_t/Address where needed.

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -25 lines)			Patch
	M	src/serialize.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
	M	src/serialize.cc	View		9 chunks	+33 lines, -25 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

I don't really know this code, so I just looked for anything obvious. There were ...

11 years, 7 months ago (2009-05-07 11:39:18 UTC) #2

Kasper Lund

11 years, 7 months ago (2009-05-07 11:48:54 UTC) #3

LGTM.

http://codereview.chromium.org/115080/diff/1/2
File src/serialize.cc (right):

http://codereview.chromium.org/115080/diff/1/2#newcode733
Line 733: return entry == NULL ? -1 :
I would put ? and : on separate lines like this:

  return entry == NULL
      ? -1
      : ....;

Expand Messages | Collapse Messages