Issue 115076: Fix lint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115076: Fix lint (Closed)

Created:
11 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix lint Committed: http://code.google.com/p/v8/source/detail?r=1896

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	src/globals.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/log.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	test/cctest/test-regexp.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-05-07 10:35:55 UTC) #3

http://codereview.chromium.org/115076/diff/1/3
File src/globals.h (right):

http://codereview.chromium.org/115076/diff/1/3#newcode85
Line 85: #else  // V8_HOST_ARCH_64_BIT
Shouldn't this comment say !V8_HOST_ARCH_64_BIT?

This nested #if stuff is complicated.  How about giving us some whitespace
before the inner #ifdef and after the inner #endif?

I actually like flattening the whole thing at this site (because there is
nothing shared between the the defined(_MSC_VER) and !defined(_MSC_VER)
versions) better:
#if V8_HOST_ARCH_64_BIT && defined(_MSC_VER)
...
#elif V8_HOST_ARCH_64_BIT
...
#else
...
#endif

Expand Messages | Collapse Messages