Changed the PageIterator class so that it only returns pages existing...

Changed the PageIterator class so that it only returns pages existing
at construction time.  If allocation during iteration causes a paged
space to expand, the iterator will not return the new pages.

This makes it more closely match the HeapObjectIterator behavior, and
it removes a possible source of bugs (if the allocation top was in the
last page in the space, the old iterator would stop only when it
reached the end of the space, potentially returning invalid pages from
a freshly expanded space).


Committed: http://code.google.com/p/v8/source/detail?r=1895

[Erik Corry, 2009-05-07 09:48:07]

LGTM.

http://codereview.chromium.org/115074/diff/1/3
File src/spaces.h (right):

http://codereview.chromium.org/115074/diff/1/3#newcode601
Line 601: };
I liked the old version better.  Does the style guide mandate this?

http://codereview.chromium.org/115074/diff/1/3#newcode843
Line 843: Page* last_page_;
The way this is updated is subtle.  It at least deserves a comment here.

[Kevin Millikin (Chromium), 2009-05-07 10:17:16]

http://codereview.chromium.org/115074/diff/1/3
File src/spaces.h (right):

http://codereview.chromium.org/115074/diff/1/3#newcode601
Line 601: };
On 2009/05/07 09:48:07, Erik Corry wrote:
> I liked the old version better.  Does the style guide mandate this?

Not mandated and we have a mix in the codebase.  I've been migrating to this....

http://codereview.chromium.org/115074/diff/1/3#newcode843
Line 843: Page* last_page_;
On 2009/05/07 09:48:07, Erik Corry wrote:
> The way this is updated is subtle.  It at least deserves a comment here.

Commented here and in the places where it's modified.