Issue 115063: Force the installation of python and svn on windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115063: Force the installation of python and svn on windows. (Closed)

Created:
11 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Force the installation of python and svn on windows. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15501

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gclient.bat	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 7 months ago (2009-05-07 03:27:26 UTC) #2

LGTM

http://codereview.chromium.org/115063/diff/1/2
File gclient.bat (right):

http://codereview.chromium.org/115063/diff/1/2#newcode15
Line 15: :: Will download svn and python if not already installed on the system.
thanks!  probably want to update this comment accordingly.  

perhaps in the future we can add support for an environment variable that would
allow people to opt-out of "force"?

Expand Messages | Collapse Messages