net/base/net_util.cc - Issue 11506: Make the net resource interface use StringPiece instead of std::string. This...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/net_util.cc

Issue 11506: Make the net resource interface use StringPiece instead of std::string. This... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: '' Created 12 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/base/net_util.cc

===================================================================

--- net/base/net_util.cc (revision 5738)

+++ net/base/net_util.cc (working copy)

@@ -800,11 +800,12 @@

#ifdef OS_WIN

std::string GetDirectoryListingHeader(const std::string& title) {

- std::string result = NetModule::GetResource(IDR_DIR_HEADER_HTML);

- if (result.empty()) {

+ static const StringPiece header(NetModule::GetResource(IDR_DIR_HEADER_HTML));

+ if (header.empty()) {

NOTREACHED() << "expected resource not found";

}

+ std::string result(header.data(), header.size());

result.append("<script>start(");

string_escape::JavascriptDoubleQuote(title, true, &result);

result.append(");</script>\n");

« no previous file with comments | « net/base/net_module.cc ('k') | net/base/registry_controlled_domain.cc » ('j') | no next file with comments »