Issue 11506: Make the net resource interface use StringPiece instead of std::string. This...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11506: Make the net resource interface use StringPiece instead of std::string. This... (Closed)

Created:
12 years, 1 month ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make the net resource interface use StringPiece instead of std::string. This means we can point directly into the resource in the binary, instead of copying. This makes sense for the TLD data, which doesn't need to be copied around. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5740

Patch Set 1 #

Patch Set 2 : '' #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -15 lines)			Patch
M	chrome/browser/browser_main.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	net/base/net_module.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	net/base/net_module.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/base/net_util.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	net/base/registry_controlled_domain.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_unittest.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/tools/test_shell/test_shell_main.cc	View	2 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

Try again with changes to test_shell. Doesn't look like the try servers compile test_shell on ...

12 years, 1 month ago (2008-11-20 01:04:44 UTC) #1

tony

12 years, 1 month ago (2008-11-20 01:07:14 UTC) #2

LG

On 2008/11/20 01:04:44, Dean McNamee wrote:
> Try again with changes to test_shell.  Doesn't look like the try servers
compile
> test_shell on Windows?

Expand Messages | Collapse Messages