Enabled Ctrl+Shift+L for POPUP and APP windows....

- Enabled Ctrl+Shift+L for POPUP and APP windows.
- Fixed crash related to Ctrl+Shift+L.

BUG=8071, 11559

[Yusuke (unused), 2009-05-06 23:56:19]

Hi Peter,
Could you review this?

[Peter Kasting, 2009-05-07 01:10:59]

http://codereview.chromium.org/115050/diff/6/7
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/115050/diff/6/7#newcode1049
Line 1049: // TODO(yusukes): give focus to the existing debugger here.
Can you just go ahead and fix this TODO in this patch?  Perhaps
DoesDebuggerExist() should become GetAnyExistingDebugger() and always return a
handle to the window, or something?  I'm not sure how the debugger works.

http://codereview.chromium.org/115050/diff/6/7#newcode2161
Line 2161: !oop_devtools && !RenderProcessHost::run_renderer_in_process());
Please move this call into the correct section above this block, as it now
doesn't depend on the window type.

[Yusuke (unused), 2009-05-07 04:08:00]

Thanks for the review.
Please take another look.

http://codereview.chromium.org/115050/diff/6/7
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/115050/diff/6/7#newcode1049
Line 1049: // TODO(yusukes): give focus to the existing debugger here.
On 2009/05/07 01:10:59, pkasting wrote:
> Can you just go ahead and fix this TODO in this patch?  Perhaps
> DoesDebuggerExist() should become GetAnyExistingDebugger() and always return a
> handle to the window, or something?  I'm not sure how the debugger works.

Done. Added some files to the change set.

http://codereview.chromium.org/115050/diff/6/7#newcode2161
Line 2161: !oop_devtools && !RenderProcessHost::run_renderer_in_process());
On 2009/05/07 01:10:59, pkasting wrote:
> Please move this call into the correct section above this block, as it now
> doesn't depend on the window type.

Sorry, I've forgotten to do that. Fixed.

[Peter Kasting, 2009-05-07 17:29:47]

LGTM

http://codereview.chromium.org/115050/diff/1023/16
File chrome/browser/debugger/debugger_window.cc (right):

http://codereview.chromium.org/115050/diff/1023/16#newcode140
Line 140: void DebuggerWindow::Focus() {
Nit: Suggestion:

Maybe if instead of being void Focus() this was bool ShowWindow(), and it
returned whether anything had been done, then the code at the beginning of
Show() above could be simplified slightly ("if (ShowWindow()) return;").

[Yusuke (unused), 2009-05-07 23:09:51]

http://codereview.chromium.org/115050/diff/1023/16
File chrome/browser/debugger/debugger_window.cc (right):

http://codereview.chromium.org/115050/diff/1023/16#newcode140
Line 140: void DebuggerWindow::Focus() {
Thanks for the suggestion. Done.

On 2009/05/07 17:29:47, pkasting wrote:
> Nit: Suggestion:
> 
> Maybe if instead of being void Focus() this was bool ShowWindow(), and it
> returned whether anything had been done, then the code at the beginning of
> Show() above could be simplified slightly ("if (ShowWindow()) return;").

[Peter Kasting, 2009-05-07 23:37:46]

Do you need me to commit this?

[Peter Kasting, 2009-05-08 19:42:24]

Landed in r15671.