Issue 115044: Add a variable and settings for -Dtarget_arch=ARM (per rtc).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115044: Add a variable and settings for -Dtarget_arch=ARM (per rtc). (Closed)

Created:
11 years, 7 months ago by sgk

Modified:
9 years, 5 months ago

Reviewers:
Mark Mentovai, Dean McNamee

CC:
chromium-reviews_googlegroups.com, ryan.cairns

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add a variable and settings for -Dtarget_arch=ARM (per Ryan Cairns). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=15467

Patch Set 1 #

Total comments: 3

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -40 lines)			Patch
	M	build/common.gypi	View		3 chunks	+59 lines, -40 lines	3 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LG otherwise http://codereview.chromium.org/115044/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/115044/diff/1/2#newcode54 Line 54: 'target_arch%': 'IA32', I would prefer not ...

11 years, 7 months ago (2009-05-06 21:08:26 UTC) #2

sgk

http://codereview.chromium.org/115044/diff/1/2 File build/common.gypi (right): http://codereview.chromium.org/115044/diff/1/2#newcode54 Line 54: 'target_arch%': 'IA32', On 2009/05/06 21:08:27, Mark Mentovai wrote: ...

11 years, 7 months ago (2009-05-06 22:38:07 UTC) #3

Dean McNamee

11 years, 7 months ago (2009-05-07 15:32:01 UTC) #4

http://codereview.chromium.org/115044/diff/1/2
File build/common.gypi (right):

http://codereview.chromium.org/115044/diff/1/2#newcode59
Line 59: 'defines': ['__ARMEL__'],
Why are we defining this?  It should be defined by the compiler.

Expand Messages | Collapse Messages