Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Side by Side Diff: src/func-name-inferrer.cc

Issue 115024: Changelist for a readability review. Not for direct commit. (Closed)
Patch Set: Second round of changes Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/func-name-inferrer.h ('k') | src/log.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are
4 // met:
5 //
6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission.
15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27
28 #include "v8.h"
29
30 #include "ast.h"
31 #include "func-name-inferrer.h"
32
33 namespace v8 {
34 namespace internal {
35
36 void FuncNameInferrer::PushEnclosingName(Handle<String> name) {
37 // Enclosing name is a name of a constructor function. To check
38 // that it is really a constructor, we check that it is not empty
39 // and starts with a capital letter.
40 if (name->length() > 0 && Runtime::IsUpperCaseChar(name->Get(0))) {
41 names_stack_.Add(name);
42 }
43 }
44
45
46 Handle<String> FuncNameInferrer::MakeNameFromStack() {
47 if (names_stack_.is_empty()) {
48 return Factory::empty_string();
49 } else {
50 return MakeNameFromStackHelper(1, names_stack_.at(0));
51 }
52 }
53
54
55 Handle<String> FuncNameInferrer::MakeNameFromStackHelper(int pos,
56 Handle<String> prev) {
57 if (pos >= names_stack_.length()) {
58 return prev;
59 } else {
60 Handle<String> curr = Factory::NewConsString(dot_, names_stack_.at(pos));
61 return MakeNameFromStackHelper(pos + 1, Factory::NewConsString(prev, curr));
62 }
63 }
64
65
66 void FuncNameInferrer::MaybeInferFunctionName() {
67 if (func_to_infer_ != NULL) {
68 func_to_infer_->set_inferred_name(MakeNameFromStack());
69 func_to_infer_ = NULL;
70 }
71 }
72
73 } // namespace internal
74 } // namespace v8
OLDNEW
« no previous file with comments | « src/func-name-inferrer.h ('k') | src/log.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698