Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Side by Side Diff: src/codegen.cc

Issue 115024: Changelist for a readability review. Not for direct commit. (Closed)
Patch Set: Second round of changes Created 11 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 188 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 } 199 }
200 200
201 return code; 201 return code;
202 } 202 }
203 203
204 204
205 #ifdef ENABLE_LOGGING_AND_PROFILING 205 #ifdef ENABLE_LOGGING_AND_PROFILING
206 206
207 bool CodeGenerator::ShouldGenerateLog(Expression* type) { 207 bool CodeGenerator::ShouldGenerateLog(Expression* type) {
208 ASSERT(type != NULL); 208 ASSERT(type != NULL);
209 if (!Logger::is_enabled()) return false; 209 if (!Logger::IsEnabled()) return false;
210 Handle<String> name = Handle<String>::cast(type->AsLiteral()->handle()); 210 Handle<String> name = Handle<String>::cast(type->AsLiteral()->handle());
211 if (FLAG_log_regexp) { 211 if (FLAG_log_regexp) {
212 static Vector<const char> kRegexp = CStrVector("regexp"); 212 static Vector<const char> kRegexp = CStrVector("regexp");
213 if (name->IsEqualTo(kRegexp)) 213 if (name->IsEqualTo(kRegexp))
214 return true; 214 return true;
215 } 215 }
216 return false; 216 return false;
217 } 217 }
218 218
219 #endif 219 #endif
(...skipping 390 matching lines...) Expand 10 before | Expand all | Expand 10 after
610 void ArgumentsAccessStub::Generate(MacroAssembler* masm) { 610 void ArgumentsAccessStub::Generate(MacroAssembler* masm) {
611 switch (type_) { 611 switch (type_) {
612 case READ_LENGTH: GenerateReadLength(masm); break; 612 case READ_LENGTH: GenerateReadLength(masm); break;
613 case READ_ELEMENT: GenerateReadElement(masm); break; 613 case READ_ELEMENT: GenerateReadElement(masm); break;
614 case NEW_OBJECT: GenerateNewObject(masm); break; 614 case NEW_OBJECT: GenerateNewObject(masm); break;
615 } 615 }
616 } 616 }
617 617
618 618
619 } } // namespace v8::internal 619 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698