Issue 115023: Add x64 header files to make the build compile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115023: Add x64 header files to make the build compile (Closed)

Created:
11 years, 7 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein, Dean McNamee, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add x64 header files to make the build compile Committed: http://code.google.com/p/v8/source/detail?r=1885

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1422 lines, -1 line)			Patch
M	src/x64/codegen-x64.h	View	1 chunk	+591 lines, -0 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	2 chunks	+345 lines, -1 line	1 comment	Download
M	src/x64/simulator-x64.h	View	1 chunk	+20 lines, -0 lines	0 comments	Download
M	src/x64/virtual-frame-x64.h	View	1 chunk	+466 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

These are almost exact copies of the ia32 files, with just a few minor touch-ups.

11 years, 7 months ago (2009-05-06 12:41:21 UTC) #1

Dean McNamee

Yeah, I am ok with just copying these files for now, we obviously know they'll ...

11 years, 7 months ago (2009-05-06 12:50:31 UTC) #2

Kevin Millikin (Chromium)

11 years, 7 months ago (2009-05-06 13:15:42 UTC) #3

I think copying is easiest to get up and running.  LGTM.

http://codereview.chromium.org/115023/diff/1/2
File src/x64/macro-assembler-x64.h (right):

http://codereview.chromium.org/115023/diff/1/2#newcode1
Line 1: // Copyright 2006-2008 the V8 project authors. All rights reserved.
Not sure why you changed this.

Expand Messages | Collapse Messages