Issue 115022: Use the correct V8_HOST_ARCH macro, it is IA32 and not X86.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115022: Use the correct V8_HOST_ARCH macro, it is IA32 and not X86. (Closed)

Created:
11 years, 7 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
iposva, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Use the correct V8_HOST_ARCH macro, it is IA32 and not X86.

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/platform-linux.cc	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

iposva

11 years, 7 months ago (2009-05-08 18:12:35 UTC) #3

http://codereview.chromium.org/115022/diff/1/2
File src/platform-linux.cc (right):

http://codereview.chromium.org/115022/diff/1/2#newcode616
Line 616: #endif
As I suggested before this would have been found earlier if you add a

#else
#error Unknown host architecture.

wherever you have a selection of architectures. Overall there should not be too
many of them.

Expand Messages | Collapse Messages