Issue 11502: Fix the FTP implementation. Our change to make the MessageLoopForIO not...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11502: Fix the FTP implementation. Our change to make the MessageLoopForIO not... (Closed)

Created:
12 years, 1 month ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Fix the FTP implementation. Our change to make the MessageLoopForIO not process windows messages broke FTP. This fixes it to work using PostTask. R=rvargas Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=5743

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -96 lines)			Patch
	M	net/url_request/url_request_inet_job.h	View		4 chunks	+4 lines, -5 lines	0 comments	Download
	M	net/url_request/url_request_inet_job.cc	View		9 chunks	+35 lines, -91 lines	0 comments	Download

Total messages: 2 (0 generated)

rvargas (doing something else)

12 years, 1 month ago (2008-11-20 00:04:53 UTC) #2

LGTM.

Shouldn't we add unit tests for ftp?