Issue 115017: X64: Changed hash computations to only use lower 32 bits of pointers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 115017: X64: Changed hash computations to only use lower 32 bits of pointers. (Closed)

Created:
11 years, 7 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Dean McNamee

CC:
v8-dev

Visibility:
Public.

Description

X64: Changed hash computations to only use lower 32 bits of pointers.

Patch Set 1 #

Total comments: 1

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	src/stub-cache.h	View		1 chunk	+6 lines, -2 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Dean McNamee

11 years, 7 months ago (2009-05-06 08:29:17 UTC) #2

Kinda sketchy, but if you think it's ok, OK.

http://codereview.chromium.org/115017/diff/1/2
File src/stub-cache.h (right):

http://codereview.chromium.org/115017/diff/1/2#newcode206
Line 206: uint32_t map_lowbits =
lowbits makes it sounds differnt than low32, specially since on a 32-bit
platform they're not low, they're the full pointer.

Expand Messages | Collapse Messages