Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 115014: Port change (r1837) that allows call-as-function handlers to be called... (Closed)

Created:
11 years, 7 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Port change (r1837) that allows call-as-function handlers to be called through new to ARM. Added simple test case of the current behavior. For consistency, changed a number of occurences of explicit moves to pc to use Jump instead. Committed: http://code.google.com/p/v8/source/detail?r=1889

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M src/arm/builtins-arm.cc View 1 5 chunks +25 lines, -5 lines 0 comments Download
M src/arm/codegen-arm.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +14 lines, -7 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (chromium)
11 years, 7 months ago (2009-05-06 07:31:09 UTC) #1
Erik Corry
11 years, 7 months ago (2009-05-06 09:26:32 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698