Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 115004: Convert lzma_sdk to gyp. (Closed)

Created:
11 years, 7 months ago by sgk
Modified:
9 years, 5 months ago
Reviewers:
sra, bradn
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/lzma_sdk/lzma_sdk.gyp View 1 chunk +60 lines, -0 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
sgk
Stephen-- Here's a rough cut at a lzma_sdk.gyp file. The CL also contains the line ...
11 years, 7 months ago (2009-05-05 23:34:11 UTC) #1
bradn
LGTM http://codereview.chromium.org/115004/diff/1/2 File third_party/lzma_sdk/lzma_sdk.gyp (right): http://codereview.chromium.org/115004/diff/1/2#newcode12 Line 12: 'type': '<(library)', when did we get a ...
11 years, 7 months ago (2009-05-05 23:37:29 UTC) #2
sgk
11 years, 7 months ago (2009-05-06 03:49:37 UTC) #3
http://codereview.chromium.org/115004/diff/1/2
File third_party/lzma_sdk/lzma_sdk.gyp (right):

http://codereview.chromium.org/115004/diff/1/2#newcode12
Line 12: 'type': '<(library)',
On 2009/05/05 23:37:29, bradn wrote:
> when did we get a library variable?

Couple weeks now; search the chromium-dev list for the thread "gyp shared
library builds on Linux".  The Linux guys have been used shared library builds
to speed up their link times.

Powered by Google App Engine
This is Rietveld 408576698