New take at implementing autofill using the editor client API

webkit/glue/editor_client_impl.h

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_GLUE_EDITOR_CLIENT_IMPL_H__
 #define WEBKIT_GLUE_EDITOR_CLIENT_IMPL_H__
 
 #include "base/compiler_specific.h"
+#include "base/task.h"
 
 #include "build/build_config.h"
 
 #include <deque>
 
 MSVC_PUSH_WARNING_LEVEL(0);
 #include "EditorClient.h"
 MSVC_POP_WARNING();
 
 namespace WebCore {
 class Frame;
+class HTMLInputElement;
 class Node;
 class PlatformKeyboardEvent;
 }
 
 class WebView;
 class WebViewImpl;
 
 class EditorClientImpl : public WebCore::EditorClient {
  public:
   EditorClientImpl(WebView* web_view);
@@ skipping 66 matching lines @@
   virtual void updateSpellingUIWithGrammarString(const WebCore::String&,
                                                  const WebCore::GrammarDetail& detail);
   virtual void updateSpellingUIWithMisspelledWord(const WebCore::String&);
   virtual void showSpellingUI(bool show);
   virtual bool spellingUIIsShowing();
   virtual void getGuessesForWord(const WebCore::String&,
                                  WTF::Vector<WebCore::String>& guesses);
   virtual void setInputMethodState(bool enabled);
 
   void SetUseEditorDelegate(bool value) { use_editor_delegate_ = value; }
-  // HACK for webkit bug #16976.
-  // TODO (timsteele): Clean this up once webkit bug 16976 is fixed.
-  void PreserveSelection();
 
   // It would be better to add these methods to the objects they describe, but
   // those are in WebCore and therefore inaccessible.
   virtual std::wstring DescribeOrError(int number, 
                                        WebCore::ExceptionCode ec);
   virtual std::wstring DescribeOrError(WebCore::Node* node, 
                                        WebCore::ExceptionCode ec);
   virtual std::wstring Describe(WebCore::Range* range);
   virtual std::wstring Describe(WebCore::Node* node);
   virtual std::wstring Describe(WebCore::EditorInsertAction action);
   virtual std::wstring Describe(WebCore::EAffinity affinity);
   virtual std::wstring Describe(WebCore::CSSStyleDeclaration* style);
 
  private:
   void ModifySelection(WebCore::Frame* frame,
                        WebCore::KeyboardEvent* event);
 
+  void DoAutofill(WebCore::HTMLInputElement* input_element, bool backspace);
+
  protected:
   WebViewImpl* web_view_;
   bool use_editor_delegate_;
   bool in_redo_;
 
-  // Should preserve the selection in next call to shouldChangeSelectedRange.
-  bool preserve_;
-
-  // Points to an HTMLInputElement that was just autocompleted (else NULL), 
-  // for use by respondToChangedContents().
-  WebCore::Element* pending_inline_autocompleted_element_;
-
   typedef std::deque<WTF::RefPtr<WebCore::EditCommand> > EditCommandStack;
   EditCommandStack undo_stack_;
   EditCommandStack redo_stack_;
+
+ private:
+  // Whether the last entered key was a backspace.
+  bool backspace_pressed_;
+
+  // The method factory used to post autofill related tasks.
+  ScopedRunnableMethodFactory<EditorClientImpl> autofill_factory_;
 };
 
 #endif  // WEBKIT_GLUE_EDITOR_CLIENT_IMPL_H__