Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: chrome_frame/test/test_with_web_server.cc

Issue 1147008: Also switching the default of the tests to default to the moniker patch.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2006-2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2006-2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 #include "chrome_frame/test/test_with_web_server.h" 4 #include "chrome_frame/test/test_with_web_server.h"
5 5
6 #include "base/file_version_info.h" 6 #include "base/file_version_info.h"
7 #include "chrome/common/chrome_switches.h" 7 #include "chrome/common/chrome_switches.h"
8 #include "chrome/installer/util/install_util.h" 8 #include "chrome/installer/util/install_util.h"
9 #include "chrome/installer/util/helper.h" 9 #include "chrome/installer/util/helper.h"
10 #include "chrome_frame/utils.h" 10 #include "chrome_frame/utils.h"
(...skipping 681 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 } 692 }
693 693
694 const wchar_t kReferrerMainTest[] = L"files/referrer_main.html"; 694 const wchar_t kReferrerMainTest[] = L"files/referrer_main.html";
695 695
696 // TODO(tommi): Still failing intermittently on the build bot. 696 // TODO(tommi): Still failing intermittently on the build bot.
697 TEST_F(ChromeFrameTestWithWebServer, FLAKY_FullTabModeIE_ReferrerTest) { 697 TEST_F(ChromeFrameTestWithWebServer, FLAKY_FullTabModeIE_ReferrerTest) {
698 // At the moment the moniker patch is only enabled if the below 698 // At the moment the moniker patch is only enabled if the below
699 // registry config value is set to PATCH_METHOD_IBROWSER_AND_MONIKER. 699 // registry config value is set to PATCH_METHOD_IBROWSER_AND_MONIKER.
700 ProtocolPatchMethod patch_method = 700 ProtocolPatchMethod patch_method =
701 static_cast<ProtocolPatchMethod>( 701 static_cast<ProtocolPatchMethod>(
702 GetConfigInt(PATCH_METHOD_IBROWSER, kPatchProtocols)); 702 GetConfigInt(PATCH_METHOD_IBROWSER_AND_MONIKER, kPatchProtocols));
703 if (patch_method != PATCH_METHOD_IBROWSER_AND_MONIKER) { 703 if (patch_method != PATCH_METHOD_IBROWSER_AND_MONIKER) {
704 LOG(ERROR) << "Not running test. Moniker patch not enabled."; 704 LOG(ERROR) << "Not running test. Moniker patch not enabled.";
705 return; 705 return;
706 } 706 }
707 707
708 SimpleBrowserTest(IE, kReferrerMainTest, L"FullTab_ReferrerTest"); 708 SimpleBrowserTest(IE, kReferrerMainTest, L"FullTab_ReferrerTest");
709 } 709 }
710 710
711 const wchar_t kSubFrameTestPage[] = L"files/full_tab_sub_frame_main.html"; 711 const wchar_t kSubFrameTestPage[] = L"files/full_tab_sub_frame_main.html";
712 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_SubFrame) { 712 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_SubFrame) {
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
788 ASSERT_TRUE(CheckResultFile(L"FullTab_AnchorURLNavigateTest", "OK")); 788 ASSERT_TRUE(CheckResultFile(L"FullTab_AnchorURLNavigateTest", "OK"));
789 } 789 }
790 790
791 // Test whether POST-ing a form from an mshtml page to a CF page will cause 791 // Test whether POST-ing a form from an mshtml page to a CF page will cause
792 // the request to get reissued. It should not. 792 // the request to get reissued. It should not.
793 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_TestPostReissue) { 793 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_TestPostReissue) {
794 // At the moment the moniker patch is only enabled if the below 794 // At the moment the moniker patch is only enabled if the below
795 // registry config value is set to PATCH_METHOD_IBROWSER_AND_MONIKER. 795 // registry config value is set to PATCH_METHOD_IBROWSER_AND_MONIKER.
796 ProtocolPatchMethod patch_method = 796 ProtocolPatchMethod patch_method =
797 static_cast<ProtocolPatchMethod>( 797 static_cast<ProtocolPatchMethod>(
798 GetConfigInt(PATCH_METHOD_IBROWSER, kPatchProtocols)); 798 GetConfigInt(PATCH_METHOD_IBROWSER_AND_MONIKER, kPatchProtocols));
799 if (patch_method != PATCH_METHOD_IBROWSER_AND_MONIKER) { 799 if (patch_method != PATCH_METHOD_IBROWSER_AND_MONIKER) {
800 LOG(ERROR) << "Not running test. Moniker patch not enabled."; 800 LOG(ERROR) << "Not running test. Moniker patch not enabled.";
801 return; 801 return;
802 } 802 }
803 803
804 MessageLoopForUI loop; // must come before the server. 804 MessageLoopForUI loop; // must come before the server.
805 805
806 // The order of pages in this array is assumed to be mshtml, cf, script. 806 // The order of pages in this array is assumed to be mshtml, cf, script.
807 const wchar_t* kPages[] = { 807 const wchar_t* kPages[] = {
808 L"full_tab_post_mshtml.html", 808 L"full_tab_post_mshtml.html",
(...skipping 20 matching lines...) Expand all
829 } 829 }
830 } 830 }
831 831
832 // Test whether following a link from an mshtml page to a CF page will cause 832 // Test whether following a link from an mshtml page to a CF page will cause
833 // multiple network requests. It should not. 833 // multiple network requests. It should not.
834 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_TestMultipleGet) { 834 TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_TestMultipleGet) {
835 // At the moment the moniker patch is only enabled if the below 835 // At the moment the moniker patch is only enabled if the below
836 // registry config value is set to PATCH_METHOD_IBROWSER_AND_MONIKER. 836 // registry config value is set to PATCH_METHOD_IBROWSER_AND_MONIKER.
837 ProtocolPatchMethod patch_method = 837 ProtocolPatchMethod patch_method =
838 static_cast<ProtocolPatchMethod>( 838 static_cast<ProtocolPatchMethod>(
839 GetConfigInt(PATCH_METHOD_IBROWSER, kPatchProtocols)); 839 GetConfigInt(PATCH_METHOD_IBROWSER_AND_MONIKER, kPatchProtocols));
840 if (patch_method != PATCH_METHOD_IBROWSER_AND_MONIKER) { 840 if (patch_method != PATCH_METHOD_IBROWSER_AND_MONIKER) {
841 LOG(ERROR) << "Not running test. Moniker patch not enabled."; 841 LOG(ERROR) << "Not running test. Moniker patch not enabled.";
842 return; 842 return;
843 } 843 }
844 844
845 MessageLoopForUI loop; // must come before the server. 845 MessageLoopForUI loop; // must come before the server.
846 846
847 // The order of pages in this array is assumed to be mshtml, cf, script. 847 // The order of pages in this array is assumed to be mshtml, cf, script.
848 const wchar_t* kPages[] = { 848 const wchar_t* kPages[] = {
849 L"full_tab_get_mshtml.html", 849 L"full_tab_get_mshtml.html",
(...skipping 13 matching lines...) Expand all
863 EXPECT_EQ("OK", r.arguments()); 863 EXPECT_EQ("OK", r.arguments());
864 864
865 if (r.arguments().compare("OK") == 0) { 865 if (r.arguments().compare("OK") == 0) {
866 // Check how many requests we got for the cf page and check that it was 866 // Check how many requests we got for the cf page and check that it was
867 // a GET. 867 // a GET.
868 int requests = server.GetRequestCountForPage(kPages[1], "GET"); 868 int requests = server.GetRequestCountForPage(kPages[1], "GET");
869 EXPECT_EQ(1, requests); 869 EXPECT_EQ(1, requests);
870 } 870 }
871 } 871 }
872 872
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698