Issue 11465: fix unittests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11465: fix unittests (Closed)

Created:
12 years, 1 month ago by tony

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

fix unittests We need to trim whitespace off the URL and handle the tricky html case by using rfind.

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
	M	base/clipboard_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	base/clipboard_util.cc	View		2 chunks	+2 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

12 years, 1 month ago (2008-11-19 02:39:33 UTC) #2

LGTM. Might you upstream these changes (in the original code)?

http://codereview.chromium.org/11465/diff/1/3
File base/clipboard_util.cc (right):

http://codereview.chromium.org/11465/diff/1/3#newcode475
Line 475: size_t markup_start = cf_html_lower.find("<html", 0);
The function we had previously (which looks like it was based off the same
webkit code) has

  .find('<', 0);

here instead of

  .find("<html",0);

I don't know which one is better. I guess you could see which one is more
recent.

Expand Messages | Collapse Messages