Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 11423: Remove the locale parameter from the StringToDouble and (Closed)

Created:
12 years, 1 month ago by tony
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews_googlegroups.com, please use my chromium address
Visibility:
Public.

Description

Remove the locale parameter from the StringToDouble and DoubleToString methods and only leave the locale independent methods. It turns out this code is only used in the json code and if people want locale formatting, they should use ICU.

Patch Set 1 #

Patch Set 2 : remove locale #

Patch Set 3 : comments #

Patch Set 4 : comments #

Patch Set 5 : more comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -131 lines) Patch
M base/json_reader.cc View 1 chunk +1 line, -2 lines 0 comments Download
M base/json_reader_unittest.cc View 2 chunks +6 lines, -1 line 0 comments Download
M base/json_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/string_util.h View 1 2 3 4 4 chunks +8 lines, -22 lines 0 comments Download
M base/string_util.cc View 1 2 3 4 14 chunks +60 lines, -104 lines 0 comments Download
M base/third_party/dmg_fp/dmg_fp.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
tony
12 years, 1 month ago (2008-11-17 22:01:35 UTC) #1
Evan Martin
http://codereview.chromium.org/11423/diff/15/213 File base/string_util.cc (right): http://codereview.chromium.org/11423/diff/15/213#newcode1002 Line 1002: char buffer[32]; Is this guaranteed? It makes me ...
12 years, 1 month ago (2008-11-17 22:37:51 UTC) #2
tony
On 2008/11/17 22:37:51, Evan Martin wrote: > http://codereview.chromium.org/11423/diff/15/213 > File base/string_util.cc (right): > > http://codereview.chromium.org/11423/diff/15/213#newcode1002 ...
12 years, 1 month ago (2008-11-17 23:27:52 UTC) #3
Evan Martin
12 years, 1 month ago (2008-11-17 23:31:46 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698