Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3170)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.h

Issue 11419041: Add tests for redirect responses from SafeBrowsingProtocolManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Reintroduce newline Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_service.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_service.h b/chrome/browser/safe_browsing/safe_browsing_service.h
index 801bf444658068348ff078920325f46c1eef4b18..5baed20db183fe2b2fa1b661216e7eb3cbc238be 100644
--- a/chrome/browser/safe_browsing/safe_browsing_service.h
+++ b/chrome/browser/safe_browsing/safe_browsing_service.h
@@ -369,7 +369,7 @@ class SafeBrowsingService
GetChunksCallback callback);
// Called on the IO thread after the database reports that it added a chunk.
- void OnChunkInserted();
+ void OnAddChunksComplete(AddChunksCallback callback);
// Notification that the database is done loading its bloom filter. We may
// have had to queue checks until the database is ready, and if so, this
@@ -379,7 +379,8 @@ class SafeBrowsingService
// Called on the database thread to add/remove chunks and host keys.
// Callee will free the data when it's done.
void HandleChunkForDatabase(const std::string& list,
- SBChunkList* chunks);
+ SBChunkList* chunks,
+ AddChunksCallback callback);
void DeleteDatabaseChunks(std::vector<SBChunkDelete>* chunk_deletes);
@@ -473,7 +474,8 @@ class SafeBrowsingService
virtual void UpdateStarted() OVERRIDE;
virtual void UpdateFinished(bool success) OVERRIDE;
virtual void GetChunks(GetChunksCallback callback) OVERRIDE;
- virtual void AddChunks(const std::string& list, SBChunkList* chunks) OVERRIDE;
+ virtual void AddChunks(const std::string& list, SBChunkList* chunks,
+ AddChunksCallback) OVERRIDE;
virtual void DeleteChunks(
std::vector<SBChunkDelete>* delete_chunks) OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698