Chromium Code Reviews| Index: base/values.h |
| diff --git a/base/values.h b/base/values.h |
| index 6b650052accf75d2e777e60e988526fbb609e078..e620483cb275757cf86259d43708b8da404a42b8 100644 |
| --- a/base/values.h |
| +++ b/base/values.h |
| @@ -114,16 +114,13 @@ class BASE_EXPORT Value { |
| static bool Equals(const Value* a, const Value* b); |
| protected: |
| - // This isn't safe for end-users (they should use the Create*Value() |
| - // static methods above), but it's useful for subclasses. |
| + // These aren't safe for end-users, but they are useful for subclasses. |
| explicit Value(Type type); |
| + Value(const Value& value); |
| + void operator=(const Value& value); |
|
brettw
2012/11/17 20:57:01
This should return Value&
|
| private: |
| - Value(); |
| - |
| Type type_; |
| - |
| - DISALLOW_COPY_AND_ASSIGN(Value); |
| }; |
| // FundamentalValue represents the simple fundamental types of values. |
| @@ -147,8 +144,6 @@ class BASE_EXPORT FundamentalValue : public Value { |
| int integer_value_; |
| double double_value_; |
| }; |
| - |
| - DISALLOW_COPY_AND_ASSIGN(FundamentalValue); |
| }; |
| class BASE_EXPORT StringValue : public Value { |
| @@ -169,8 +164,6 @@ class BASE_EXPORT StringValue : public Value { |
| private: |
| std::string value_; |
| - |
| - DISALLOW_COPY_AND_ASSIGN(StringValue); |
| }; |
| class BASE_EXPORT BinaryValue: public Value { |