Issue 11417011: Move werror variable declation to non-conditional block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11417011: Move werror variable declation to non-conditional block. (Closed)

Created:
8 years, 1 month ago by Sam Clegg

Modified:
8 years, 1 month ago

Reviewers:
Mark Seaborn, bradnelson

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move werror variable declation to non-conditional block. Previously it was linux only, but a native_client's untrusted.gypi is about the rely on werror existing on all platforms. BUG=

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -3 lines)			Patch
	M	build/common.gypi	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Clegg

This is pre-requisite for integration of a pending native-client side change: http://codereview.chromium.org/11363175/

8 years, 1 month ago (2012-11-15 19:23:01 UTC) #1

Sam Clegg

8 years, 1 month ago (2012-11-15 20:44:28 UTC) #2

On 2012/11/15 19:23:01, Sam Clegg wrote:
> This is pre-requisite for integration of a pending 
> native-client side change:
> 
> http://codereview.chromium.org/11363175/

Aborting this change in favour of not using the werror variable in
untrusted.gypi at all and just hardcoding -Werror.

Expand Messages | Collapse Messages