Issue 1141010: Auxiliary function for args checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1141010: Auxiliary function for args checks. (Closed)

Created:
10 years, 9 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Visibility:
Public.

Patch Set 2 : fix typo and reformat comment #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -0 lines)			Patch
	M	src/scripts/common.sh	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ comment http://codereview.chromium.org/1141010/diff/1/2 File src/scripts/common.sh (right): http://codereview.chromium.org/1141010/diff/1/2#newcode262 src/scripts/common.sh:262: # Usage: check_flags_only_and_allow_null_arg "$@" && set ...

10 years, 9 months ago (2010-03-23 17:40:34 UTC) #2

Luigi Semenzato

10 years, 9 months ago (2010-03-23 18:01:40 UTC) #3

Thanks.

For the record: adlr and I investigated this issue in depth, and found that the
meaning of -e applies only to isolated commands.  Expressions with multiple
operands and function calls do not force exit when -e is set.  For instance, the
expression "false" forces an exit, but "false && true" does not.  Another great
moment in the history of computing.

Expand Messages | Collapse Messages

Issue 1141010: Auxiliary function for args checks. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix typo and reformat comment #

Messages