Refactor FFmpegURLProtocol code from FFmpegDemuxer into BlockingUrlProtocol.

media/filters/file_data_source.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_FILTERS_FILE_DATA_SOURCE_H_
 #define MEDIA_FILTERS_FILE_DATA_SOURCE_H_
 
 #include <string>
 
 #include "base/gtest_prod_util.h"
 #include "base/synchronization/lock.h"
 #include "media/base/data_source.h"
 
 namespace media {
 
 // Basic data source that treats the URL as a file path, and uses the file
 // system to read data for a media pipeline.
 class MEDIA_EXPORT FileDataSource : public DataSource {
  public:
   FileDataSource();
-  FileDataSource(bool disable_file_size);
 
   bool Initialize(const std::string& url);
 
   // Implementation of DataSource.
   virtual void set_host(DataSourceHost* host) OVERRIDE;
   virtual void Stop(const base::Closure& callback) OVERRIDE;
   virtual void Read(int64 position, int size, uint8* data,
                     const DataSource::ReadCB& read_cb) OVERRIDE;
   virtual bool GetSize(int64* size_out) OVERRIDE;
   virtual bool IsStreaming() OVERRIDE;
   virtual void SetBitrate(int bitrate) OVERRIDE;
 
+  // Unit test helpers. Recreate the object if you want the default behaviour.
+  void disable_file_size_for_testing() { disable_file_size_ = true; }

[DaleCurtis, 2012/11/13 03:42:28]

This isn't used anywhere in this CL. Remove?

[scherkus (not reviewing), 2012/11/13 18:19:13]

Done.

+  void force_read_errors_for_testing() { force_read_errors_ = true; }
+  void force_streaming_for_testing() { force_streaming_ = true; }
+
  protected:
   virtual ~FileDataSource();
 
  private:
   // Informs the host of changes in total and buffered bytes.
   void UpdateHostBytes();
 
   // File handle.  NULL if not initialized or an error occurs.
   FILE* file_;
 
   // Size of the file in bytes.
   int64 file_size_;
 
-  // True if the FileDataSource should ignore its set file size, false
-  // otherwise.
+  // Serialize all operations to prevent stopping during reads.
+  base::Lock lock_;
+
   bool disable_file_size_;
-
-  // Critical section that protects all of the DataSource methods to prevent
-  // a Stop from happening while in the middle of a file I/O operation.
-  // TODO(ralphl): Ideally this would use asynchronous I/O or we will know
-  // that we will block for a short period of time in reads.  Otherwise, we can
-  // hang the pipeline Stop.
-  base::Lock lock_;
+  bool force_read_errors_;
+  bool force_streaming_;
 
   DISALLOW_COPY_AND_ASSIGN(FileDataSource);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_FILTERS_FILE_DATA_SOURCE_H_