chrome/browser/views/tabs/tab.cc - Issue 1141005: Revert r42156, r42157, r42160. Allow dynamic switching in and out of sidetabs...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/tabs/tab.cc

Issue 1141005: Revert r42156, r42157, r42160. Allow dynamic switching in and out of sidetabs... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/views/tabs/tab.cc

===================================================================

--- chrome/browser/views/tabs/tab.cc (revision 42174)

+++ chrome/browser/views/tabs/tab.cc (working copy)

@@ -51,9 +51,9 @@

// Overridden from menus::SimpleMenuModel::Delegate:

virtual bool IsCommandIdChecked(int command_id) const {

- return tab_ && tab_->delegate()->IsCommandCheckedForTab(

- static_cast<TabStripModel::ContextMenuCommand>(command_id),

- tab_);

+ if (!tab_ || command_id != TabStripModel::CommandTogglePinned)

+ return false;

+ return tab_->delegate()->IsTabPinned(tab_);

}

virtual bool IsCommandIdEnabled(int command_id) const {

return tab_ && tab_->delegate()->IsCommandEnabledForTab(

« no previous file with comments | « chrome/browser/views/tabs/tab.h ('k') | chrome/browser/views/tabs/tab_strip.h » ('j') | no next file with comments »