Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1758)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1141005: Revert r42156, r42157, r42160. Allow dynamic switching in and out of sidetabs... (Closed)

Created:
10 years, 9 months ago by Lei Zhang
Modified:
9 years, 7 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, John Grabowski, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert r42156, r42157, r42160. Allow dynamic switching in and out of sidetabs mode. Reliability bot and Linux CrOS browser_tests all had crashes in ~TabStrip. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42176

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -341 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/browser.h View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/browser.cc View 3 chunks +1 line, -11 lines 0 comments Download
M chrome/browser/browser_window.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/browser_window_cocoa.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/gtk/browser_window_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/browser_window_gtk.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/tab_menu_model.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.h View 3 chunks +0 lines, -11 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model.cc View 2 chunks +2 lines, -22 lines 0 comments Download
M chrome/browser/tabs/tab_strip_model_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/browser_frame.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/views/frame/browser_frame_gtk.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_frame_gtk.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/frame/browser_frame_win.h View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/views/frame/browser_frame_win.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/views/frame/browser_view.cc View 4 chunks +11 lines, -32 lines 0 comments Download
M chrome/browser/views/frame/browser_view_layout.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/views/frame/glass_browser_frame_view.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/views/tabs/browser_tab_strip_controller.h View 4 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/views/tabs/browser_tab_strip_controller.cc View 3 chunks +0 lines, -102 lines 0 comments Download
M chrome/browser/views/tabs/side_tab.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/views/tabs/side_tab.cc View 3 chunks +5 lines, -21 lines 0 comments Download
M chrome/browser/views/tabs/side_tab_strip.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/views/tabs/side_tab_strip.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/views/tabs/side_tab_strip_model.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/views/tabs/tab.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/views/tabs/tab.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip.cc View 3 chunks +2 lines, -22 lines 0 comments Download
M chrome/test/test_browser_window.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
10 years, 9 months ago (2010-03-20 00:16:35 UTC) #1
James Hawkins
10 years, 9 months ago (2010-03-20 00:17:21 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698