Added a ResourceMessageFilter for handling resource messages on another thread.

ppapi/host/ppapi_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/host/ppapi_host.h"
 
 #include "base/logging.h"
 #include "ppapi/c/pp_errors.h"
 #include "ppapi/host/host_factory.h"
 #include "ppapi/host/host_message_context.h"
@@ skipping 100 matching lines @@
   // Stash the |reply_msg| in the context so that it can be used to reply
   // to the sync message.
   HostMessageContext context(params, reply_msg);
   HandleResourceCall(params, nested_msg, &context);
 }
 
 void PpapiHost::HandleResourceCall(
     const proxy::ResourceMessageCallParams& params,
     const IPC::Message& nested_msg,
     HostMessageContext* context) {
-  ReplyMessageContext reply_context = context->MakeReplyMessageContext();
-
   ResourceHost* resource_host = GetResourceHost(params.pp_resource());
   if (resource_host) {
-    reply_context.params.set_result(
-        resource_host->OnResourceMessageReceived(nested_msg, context));
-
-    // Sanity check the resource handler. Note if the result was
-    // "completion pending" the resource host may have already sent the reply.
-    if (reply_context.params.result() == PP_OK_COMPLETIONPENDING) {
-      // Message handler should have only returned a pending result if a
-      // response will be sent to the plugin.
-      DCHECK(params.has_callback());
-
-      // Message handler should not have written a message to be returned if
-      // completion is pending.
-      DCHECK(context->reply_msg.type() == 0);
-    } else if (!params.has_callback()) {
-      // When no response is required, the message handler should not have
-      // written a message to be returned.
-      DCHECK(context->reply_msg.type() == 0);
-
-      // If there is no callback and the result of running the message handler
-      // was not PP_OK the client won't find out.
-      DLOG_IF(WARNING, reply_context.params.result() != PP_OK)
-          << "'Post' message handler failed to complete successfully.";
-    }
+    resource_host->HandleMessage(nested_msg, context);
   } else {
+    ReplyMessageContext reply_context = context->MakeReplyMessageContext();
     reply_context.params.set_result(PP_ERROR_BADRESOURCE);
+    SendReply(reply_context, context->reply_msg);

[yzshen1, 2012/11/13 21:51:48]

Maybe the message doesn't expect a reply.

[raymes, 2012/11/16 18:56:35]

Done.

   }
-
-  if (params.has_callback() &&
-      reply_context.params.result() != PP_OK_COMPLETIONPENDING)
-    SendReply(reply_context, context->reply_msg);
 }
 
 void PpapiHost::OnHostMsgResourceCreated(
     const proxy::ResourceMessageCallParams& params,
     PP_Instance instance,
     const IPC::Message& nested_msg) {
   if (resources_.size() >= kMaxResourcesPerPlugin)
     return;
 
   // Run through all filters until one grabs this message.
@@ skipping 23 matching lines @@
   resources_.erase(found);
 }
 
 ResourceHost* PpapiHost::GetResourceHost(PP_Resource resource) {
   ResourceMap::iterator found = resources_.find(resource);
   return found == resources_.end() ? NULL : found->second.get();
 }
 
 }  // namespace host
 }  // namespace ppapi