Issue 114082: Improve the presubmit_canned_checks testing by using a real mock and testing for more cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 114082: Improve the presubmit_canned_checks testing by using a real mock and testing for more cases. (Closed)

Created:
11 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Jói Sigurðsson

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Improve the presubmit_canned_checks testing by using a real mock and testing for more cases. Remove a superfluous check in CheckLongLines(). Add unittest to InputApi. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=17805

Patch Set 1 #

Patch Set 2 : Refactoring #

Patch Set 3 : bump version #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -145 lines)			Patch
M	presubmit_canned_checks.py	View	1	2 chunks	+12 lines, -18 lines	0 comments	Download
M	presubmit_support.py	View	1 2	5 chunks	+6 lines, -1 line	0 comments	Download
M	tests/presubmit_unittest.py	View	1	5 chunks	+176 lines, -126 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages